fix(proxy): SOCKS split message parsing fix - #308
Merged
seanmonstar merged 3 commits intoJul 31, 2026
Conversation
- test for "incomplete" message parsing - test for Address::Domain parsing bug
- incomplete message tests fixed by parsing through a view - domain parsing fixed by consuming domain length
monosans
added a commit
to monosans/hyper-util
that referenced
this pull request
Aug 1, 2026
… NULL Merging master brought in the `v4::messages` unit tests added by hyperium#308. They encode the pre-fix 10-byte request -- an empty USERID byte followed by a separate NULL -- so with the extra byte removed on this branch both `request_serialization_with_socket` and `request_serialization_with_domain` asserted the old expectation and failed. Drop the duplicated NULL from both expected buffers. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes hyperium/hyper#4127
Messages that arrived in two read calls were not parsed properly due to the bytes being consumed. Now using a view into the buffer and only advancing upon receiving a complete message.
Also fixed an Address parsing bug and wrote tests for (de)serializing messages.